Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Note about changes related to upgrade to GridBundle 1.10 #12881

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? master

Should be merged after merge PR Sylius/SyliusGridBundle#68 and release new version of SyliusGridBundle

@AdamKasp AdamKasp requested a review from a team as a code owner August 12, 2021 06:57
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Aug 12, 2021
@vvasiloi
Copy link
Contributor

Now that I see this I think the checklist should've also contained 'add global parameters that apply to all grids'.

@vvasiloi
Copy link
Contributor

vvasiloi commented Aug 12, 2021

Oh, wait... there were global params, but you removed them... never mind.

@AdamKasp
Copy link
Contributor Author

@vvasiloi yes I removed them because we decided to have by default true for both and add this doc :)

@AdamKasp AdamKasp force-pushed the add-snippet-with-fetch-collection-and-output-walkers-disabling branch from 3a88f1f to f579ca9 Compare August 12, 2021 09:40
@AdamKasp AdamKasp changed the title docs about fetch join collection and output walkers [WIP] docs about fetch join collection and output walkers Aug 17, 2021
@GSadee
Copy link
Member

GSadee commented Aug 18, 2021

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "add-snippet-with-fetch-collection-and-output-walkers-disabling" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee changed the base branch from master to 1.9 August 18, 2021 10:19
@GSadee GSadee force-pushed the add-snippet-with-fetch-collection-and-output-walkers-disabling branch from f579ca9 to e489775 Compare August 18, 2021 10:19
docs/customization/grid.rst Outdated Show resolved Hide resolved
docs/customization/grid.rst Outdated Show resolved Hide resolved
docs/customization/grid.rst Outdated Show resolved Hide resolved
@GSadee GSadee force-pushed the add-snippet-with-fetch-collection-and-output-walkers-disabling branch from faa5cab to d70f712 Compare August 18, 2021 10:29
@GSadee GSadee changed the title [WIP] docs about fetch join collection and output walkers [Documentation] Note about changes related to upgrade to GridBundle 1.10 Aug 18, 2021
Changes related to upgrade to GridBundle 1.10
---------------------------------------------

In SyliusGridBundle all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In SyliusGridBundle all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default.
Since the SyliusGridBundle v1.10, all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default.

@lchrusciel lchrusciel merged commit 2107343 into Sylius:1.9 Aug 18, 2021
@lchrusciel
Copy link
Member

lchrusciel commented Aug 18, 2021

Thank you, Adam & Grzegorz! 🎉

lchrusciel added a commit that referenced this pull request Aug 18, 2021
This PR was merged into the 1.9 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | 1.9
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes #12881 (review)
| License         | MIT


Commits
-------

eb121ac [Documentation] Minor fix in grids docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants