New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation] Note about changes related to upgrade to GridBundle 1.10 #12881
[Documentation] Note about changes related to upgrade to GridBundle 1.10 #12881
Conversation
Now that I see this I think the checklist should've also contained 'add global parameters that apply to all grids'. |
Oh, wait... there were global params, but you removed them... never mind. |
@vvasiloi yes I removed them because we decided to have by default |
3a88f1f
to
f579ca9
Compare
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
f579ca9
to
e489775
Compare
faa5cab
to
d70f712
Compare
Changes related to upgrade to GridBundle 1.10 | ||
--------------------------------------------- | ||
|
||
In SyliusGridBundle all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SyliusGridBundle all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default. | |
Since the SyliusGridBundle v1.10, all grids has options `fetch_join_collection` and `use_output_walkers` enabled by default. |
Thank you, Adam & Grzegorz! 🎉 |
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #12881 (review) | License | MIT Commits ------- eb121ac [Documentation] Minor fix in grids docs
Should be merged after merge PR Sylius/SyliusGridBundle#68 and release new version of
SyliusGridBundle