Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Rename original_price to originalPrice in api responses #12883

Merged
merged 2 commits into from Aug 13, 2021
Merged

[API] Rename original_price to originalPrice in api responses #12883

merged 2 commits into from Aug 13, 2021

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Aug 12, 2021 •
edited

Q A
Branch? master
Bug fix? yes
License MIT

@AdamKasp AdamKasp added the API APIs related issues and PRs. label Aug 12, 2021
@AdamKasp AdamKasp requested a review from a team as a code owner August 12, 2021 11:44
@arti0090 arti0090 force-pushed the fix-normalized-original-price-name branch from 5ca2f43 to 3f7260f Compare August 13, 2021 09:03
@arti0090 arti0090 mentioned this pull request Aug 13, 2021
Merged
@lchrusciel lchrusciel merged commit a64f77b into Sylius:master Aug 13, 2021
@lchrusciel
Copy link
Member

lchrusciel commented Aug 13, 2021 •
edited

Thank you, Adam and Artur! 🥇

AdamKasp added a commit that referenced this pull request Aug 13, 2021
@AdamKasp
minor #12889 Original price behat fix (arti0090)
397685d 
This PR was merged into the 1.11-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         |  master 
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | fixes for #12877
| License         | MIT

! MERGE #12883 FIRST

Commits
-------

d88eed4 Change the behat implementation to be more strict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamKasp @lchrusciel @arti0090