[DOCS] Generating invoice after payment #12887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Aug 13, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
the
Documentation
lchrusciel
reviewed
Aug 13, 2021
arti0090
force-pushed
the
invoice-after-payment
branch
3 times, most recently
from
bc33d46
to
88bc0ec
Compare
Tomanhez
approved these changes
Aug 13, 2021
AdamKasp
reviewed
Aug 13, 2021
| } | ||
| } | ||
|
|
||
| **2.** The ``NoInvoiceOnOrderPlacedListener`` will not do anything (what a lazy boy), but as we are changing the behavior, it still has very important role: |
There was a problem hiding this comment.
you can also remove this service from the container, but I am not sure if it will be a better or a different solution :)
There was a problem hiding this comment.
Well, that's true but I think this is the easier solution ( and much consistent with other cookbooks).
arti0090
force-pushed
the
invoice-after-payment
branch
from
88bc0ec
to
68cb082
Compare
AdamKasp
approved these changes
Aug 16, 2021
GSadee
approved these changes
Aug 17, 2021
Co-authored-by: Grzegorz Sadowski <sadowskigp@gmail.com>
|
Thank you, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.