Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix borders in order - show - addresses #12973

Merged
merged 1 commit into from Aug 18, 2021
Merged

Fix borders in order - show - addresses #12973

merged 1 commit into from Aug 18, 2021

Conversation

pavol-tuka
Copy link
Contributor

I think it was OK until shipping address was first. Now the logic is inverted, so this change is needed to fix ugly address borders.

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

I think it was OK until shipping address was first. Now the logic is inverted, so this change is needed to fix ugly address borders.
@pavol-tuka pavol-tuka requested a review from a team as a code owner August 18, 2021 09:16
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Aug 18, 2021
@lchrusciel
Copy link
Member

Hey Pavol,

thanks a lot for your contribution. Could you share screenshots before and after the change?

@pavol-tuka
Copy link
Contributor Author

Before (missing top border on billing address):
image

After:
image

@lchrusciel
Copy link
Member

Thanks a lot!

@lchrusciel
Copy link
Member

Thank you, Pavol! 🥇

@lchrusciel lchrusciel merged commit ceaf655 into Sylius:1.9 Aug 18, 2021
@pavol-tuka pavol-tuka deleted the patch-1 branch August 18, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants