[API] Resend verification email refactor to take current user from the security context #12978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lchrusciel
commented
Aug 18, 2021
lchrusciel
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | |
| License | MIT |
lchrusciel
force-pushed
the
verification-refactor
branch
2 times, most recently
from
16b2ed3
to
cf84fc6
Compare
stloyd
reviewed
Aug 18, 2021
|
|
||
| /** @experimental */ | ||
| class ResendVerificationEmail implements ChannelCodeAwareInterface, LocaleCodeAwareInterface, IriToIdentifierConversionAwareInterface | ||
| class ResendVerificationEmail implements ShopUserIdAwareInterface, ChannelCodeAwareInterface, LocaleCodeAwareInterface, IriToIdentifierConversionAwareInterface |
There was a problem hiding this comment.
Suggested change
| class ResendVerificationEmail implements ShopUserIdAwareInterface, ChannelCodeAwareInterface, LocaleCodeAwareInterface, IriToIdentifierConversionAwareInterface | |
| final class ResendVerificationEmail implements ShopUserIdAwareInterface, ChannelCodeAwareInterface, LocaleCodeAwareInterface, IriToIdentifierConversionAwareInterface |
There was a problem hiding this comment.
I agree, that this approach would be more proper from the clean code perspective, but we've decided to leave commands open, as they are simple DTOs and it makes it easier to extend basic logic
src/Sylius/Bundle/ApiBundle/Command/Account/ResendVerificationEmail.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Command/Account/ResendVerificationEmail.php
Outdated
Show resolved
Hide resolved
lchrusciel
force-pushed
the
verification-refactor
branch
from
cf84fc6
to
d9388d6
Compare
stloyd
reviewed
Aug 18, 2021
src/Sylius/Bundle/ApiBundle/Command/Account/ResendVerificationEmail.php
Outdated
Show resolved
Hide resolved
lchrusciel
force-pushed
the
verification-refactor
branch
2 times, most recently
from
1a25a4a
to
736a6c8
Compare
GSadee
approved these changes
Aug 19, 2021
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/VerifyCustomerAccount.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/Taxon.xml
Outdated
Show resolved
Hide resolved
lchrusciel
force-pushed
the
verification-refactor
branch
2 times, most recently
from
473b46e
to
770e1a2
Compare
…e security context
lchrusciel
force-pushed
the
verification-refactor
branch
from
770e1a2
to
f247e3e
Compare
probot-autolabeler
bot
added
the
Maintenance
|
Thanks, Łukasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.