Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Expose taxon children as IRI in menu endpoint #12980

Merged
merged 1 commit into from Aug 19, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

@lchrusciel lchrusciel added Feature New feature proposals. API APIs related issues and PRs. labels Aug 18, 2021
@lchrusciel lchrusciel requested a review from a team as a code owner August 18, 2021 13:25
Comment on lines +1 to +23
Sylius\Component\Core\Model\Channel:
gb_web_channel:
code: "WEB_GB"
name: "Great Britain Channel"
hostname: "localhost"
description: "Lorem ipsum"
baseCurrency: "@dolar"
defaultLocale: "@locale_en_us"
locales: ["@locale_en_us", "@locale_de_de"]
color: "black"
menuTaxon: '@category_taxon'
enabled: true
taxCalculationStrategy: "order_items_based"

Sylius\Component\Currency\Model\Currency:
dolar:
code: USD

Sylius\Component\Locale\Model\Locale:
locale_en_us:
code: en_US
locale_de_de:
code: de_DE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These fixtures can be extracted to a separate file

@GSadee GSadee merged commit 40960da into Sylius:master Aug 19, 2021
@GSadee
Copy link
Member

GSadee commented Aug 19, 2021

Thanks, Łukasz! 🎉

@lchrusciel lchrusciel deleted the add-taxon-children branch August 19, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants