Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Refactor current customer email aware commands #12981

Merged
merged 1 commit into from Aug 23, 2021
Merged

[API] Refactor current customer email aware commands #12981

merged 1 commit into from Aug 23, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets
License MIT

@lchrusciel lchrusciel requested a review from a team as a code owner August 18, 2021 14:04
@probot-autolabeler probot-autolabeler bot added API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc. labels Aug 18, 2021
GSadee
GSadee approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the rebase is needed

...ndle/ApiBundle/spec/DataTransformer/LoggedInCustomerEmailAwareCommandDataTransformerSpec.php Outdated Show resolved Hide resolved
@lchrusciel lchrusciel force-pushed the customer-email-transformer branch 2 times, most recently from e7b2464 to b5bd764 Compare August 19, 2021 07:37
@GSadee GSadee merged commit c0203dc into Sylius:master Aug 23, 2021
@GSadee
Copy link
Member

GSadee commented Aug 23, 2021

Thanks, Łukasz! 🥇

@lchrusciel lchrusciel deleted the customer-email-transformer branch August 30, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Arminek Arminek Arminek approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lchrusciel @GSadee @Arminek