Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog Promotions] Add behat scenarios for endpoints #13008

Merged
merged 5 commits into from
Aug 26, 2021
Merged

[Catalog Promotions] Add behat scenarios for endpoints #13008

merged 5 commits into from
Aug 26, 2021

Conversation

arti0090
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes (behat for feature)
BC breaks? no
Deprecations? no
License MIT

Promised behats for #12994

@arti0090 arti0090 requested a review from a team as a code owner August 26, 2021 06:18
@arti0090 arti0090 force-pushed the catalog-promo-endpoints-behats branch from f0919e3 to c1c5442 Compare August 26, 2021 06:21
@arti0090 arti0090 changed the title Catalog promo endpoints behats [Catalog Promotions] Add behat scenarios for endpoints Aug 26, 2021
@arti0090 arti0090 force-pushed the catalog-promo-endpoints-behats branch 2 times, most recently from 08a9a3a to e6e7b07 Compare August 26, 2021 07:20
GSadee
GSadee reviewed Aug 26, 2021
View reviewed changes
features/promotion/managing_catalog_promotions/editing_catalog_promotion.feature Outdated Show resolved Hide resolved
features/promotion/managing_catalog_promotions/editing_catalog_promotion.feature Outdated Show resolved Hide resolved
features/promotion/managing_catalog_promotions/editing_catalog_promotion.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Transform/CatalogPromotionContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Transform/CatalogPromotionContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/services/contexts/setup.xml Outdated Show resolved Hide resolved
src/Sylius/Behat/Resources/config/services/contexts/transform.xml Outdated Show resolved Hide resolved
src/Sylius/Component/Core/Test/Factory/TestCatalogPromotionFactory.php Outdated Show resolved Hide resolved
@Zales0123 Zales0123 added the Feature New feature proposals. label Aug 26, 2021
@GSadee GSadee added the API APIs related issues and PRs. label Aug 26, 2021
@arti0090 arti0090 force-pushed the catalog-promo-endpoints-behats branch 2 times, most recently from 8028c2e to c2cd342 Compare August 26, 2021 09:45
@arti0090 arti0090 force-pushed the catalog-promo-endpoints-behats branch from c2cd342 to f035d45 Compare August 26, 2021 10:44
@arti0090 arti0090 force-pushed the catalog-promo-endpoints-behats branch from f035d45 to 2912c4f Compare August 26, 2021 11:01
@GSadee GSadee merged commit 90d8281 into Sylius:master Aug 26, 2021
@GSadee
Copy link
Member

GSadee commented Aug 26, 2021

Thanks, @arti0090! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arti0090 @GSadee @Zales0123