Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix default sylius config file path in Sylius 1.9 #13019

Merged
merged 1 commit into from Aug 30, 2021

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Aug 27, 2021

Q A
Branch? 1.9
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

There is no such file as app/config/packages/_sylius.yaml. App prefix is not needed, because related configuration should be placed in: https://github.com/Sylius/Sylius-Standard/blob/1.10/config/packages/_sylius.yaml

This PR contains fixes to 1.8 as well, as I'm not sure if we want to merge then on previous branch

@lchrusciel lchrusciel added Maintenance CI configurations, READMEs, releases, etc. Bug Confirmed bugs or bugfixes. labels Aug 27, 2021
@lchrusciel lchrusciel requested a review from a team as a code owner August 27, 2021 14:02
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Aug 27, 2021
@@ -1,6 +1,6 @@
# UPGRADE FROM `v1.8.4` TO `v1.8.6`

1. Api is disabled by default, to enable it you need to set flag ``sylius_api.enabled`` to ``true`` in ``app/config/packages/_sylius.yaml``.
1. Api is disabled by default, to enable it you need to set flag ``sylius_api.enabled`` to ``true`` in ``config/packages/_sylius.yaml``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed after #13018

@@ -1,6 +1,6 @@
# UPGRADE FROM `v1.8.4` TO `v1.8.6`

1. API is disabled by default, to enable it you need to set flag to ``true`` in ``app/config/packages/_sylius.yaml``:
1. API is disabled by default, to enable it you need to set flag to ``true`` in ``config/packages/_sylius.yaml``:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed after #13018

@@ -5,7 +5,7 @@ Introduction

The new, unified Sylius API is still under development, that's why the whole ``ApiBundle`` is tagged with ``@experimental``.
This means that all code from ``ApiBundle`` is excluded from :doc:`Backward Compatibility Promise </book/organization/backward-compatibility-promise>`.
You can enable entire API by changing the flag ``sylius_api.enabled`` to ``true`` in ``app/config/packages/_sylius.yaml``.
You can enable entire API by changing the flag ``sylius_api.enabled`` to ``true`` in ``config/packages/_sylius.yaml``.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed after #13018

@GSadee GSadee dismissed CoderMaggie’s stale review August 30, 2021 05:02

It will be resolved automatically

@GSadee GSadee merged commit fd4efe1 into Sylius:1.9 Aug 30, 2021
@GSadee
Copy link
Member

GSadee commented Aug 30, 2021

Thanks, Łukasz! 🎉

@lchrusciel lchrusciel deleted the config-file-1.9 branch August 30, 2021 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bugs or bugfixes. Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants