Add validation for Catalog Promotion Rules #13030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Aug 30, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
AdamKasp
force-pushed
the
add-validation-to-catalog-promotion-rules
branch
2 times, most recently
from
45e26d3
to
7631614
Compare
arti0090
reviewed
Aug 31, 2021
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidity.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidityValidator.php
Outdated
Show resolved
Hide resolved
Arminek
reviewed
Aug 31, 2021
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
Zales0123
reviewed
Aug 31, 2021
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidity.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidity.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidityValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/CatalogPromotionRulesValidity.php
Outdated
Show resolved
Hide resolved
.../Bundle/CoreBundle/spec/Validator/Constraints/CatalogPromotionRulesValidityValidatorSpec.php
Outdated
Show resolved
Hide resolved
.../Bundle/CoreBundle/spec/Validator/Constraints/CatalogPromotionRulesValidityValidatorSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
add-validation-to-catalog-promotion-rules
branch
from
7631614
to
b92dbb5
Compare
AdamKasp
force-pushed
the
add-validation-to-catalog-promotion-rules
branch
from
b92dbb5
to
cbf4b85
Compare
AdamKasp
changed the title
AdamKasp
force-pushed
the
add-validation-to-catalog-promotion-rules
branch
3 times, most recently
from
e868ae2
to
a6143c1
Compare
GSadee
reviewed
Sep 1, 2021
features/promotion/managing_catalog_promotions/validating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
features/promotion/managing_catalog_promotions/validating_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/translations/validators.en.yml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/ValidCatalogPromotionRulesValidator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Validator/Constraints/ValidCatalogPromotionRulesValidator.php
Outdated
Show resolved
Hide resolved
...ius/Bundle/CoreBundle/spec/Validator/Constraints/ValidCatalogPromotionRulesValidatorSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
add-validation-to-catalog-promotion-rules
branch
from
a6143c1
to
0977cc5
Compare
AdamKasp
force-pushed
the
add-validation-to-catalog-promotion-rules
branch
from
0977cc5
to
9222e3a
Compare
GSadee
approved these changes
Sep 2, 2021
|
Thank you, Adam! 🎉 |
GSadee
reviewed
Sep 2, 2021
|
|
||
| <constraint-mapping xmlns="http://symfony.com/schema/dic/constraint-mapping" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://symfony.com/schema/dic/constraint-mapping http://symfony.com/schema/dic/services/constraint-mapping-1.0.xsd"> | ||
| <class name="Sylius\Component\Promotion\Model\CatalogPromotion"> | ||
| <property name="rules"> |
There was a problem hiding this comment.
The constraint could be defined on the CatalogPromotionRule entity 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.