[CatalogPromotions] Inform about promotions applied on variants #13035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arminek
reviewed
Aug 31, 2021
Arminek
approved these changes
Aug 31, 2021
arti0090
reviewed
Aug 31, 2021
src/Sylius/Bundle/CoreBundle/Applicator/CatalogPromotionApplicator.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Aug 31, 2021
src/Sylius/Bundle/CoreBundle/Migrations/Version20210830193340.php
Outdated
Show resolved
Hide resolved
| @@ -30,6 +30,9 @@ class ChannelPricing implements ChannelPricingInterface | |||
| /** @var int|null */ | |||
| protected $originalPrice; | |||
|
|
|||
| /** @var array */ | |||
| protected $appliedPromotions = []; | |||
There was a problem hiding this comment.
Nothing to change right now, but just a question for the future - do we plan to have object references here?
There was a problem hiding this comment.
I don't know yet - we will see what needs we will have when the feature would be growing. But I do not rule it out 🖖
GSadee
reviewed
Sep 1, 2021
| /** @var string $code */ | ||
| $code = $catalogPromotion->getCode(); | ||
|
|
||
| return [$code => ['name' => $label]]; |
There was a problem hiding this comment.
If we are saving only one label in one translation, there will be no possibility to translate this label on variants 🤔
There was a problem hiding this comment.
Indeed. Probably we should save the label in each locale - it makes this data structure a little bit more complicated, but benefits are undeniable. I would provide is as an improvement in the separate PR, wdyt?
AdamKasp
reviewed
Sep 1, 2021
src/Sylius/Bundle/CoreBundle/Applicator/CatalogPromotionApplicator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Applicator/CatalogPromotionApplicator.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/DummyCatalogPromotionProcessor.php
Outdated
Show resolved
Hide resolved
- improve behat steps configuration - add description to migration
Zales0123
force-pushed
the
inform-about-applied-catalog-promotion-on-variants-list
branch
from
802246c
to
f59b034
Compare
GSadee
approved these changes
Sep 1, 2021
|
Thank you, Mateusz! 🎉 |
Zales0123
deleted the
inform-about-applied-catalog-promotion-on-variants-list
branch
SirDomin
added a commit
that referenced
this pull request
Sep 7, 2021
… on variant` (arti0090) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT Scenario that will extend #13035 Commits ------- f4585fd [CP] Add scenario for variant
GSadee
added a commit
that referenced
this pull request
Sep 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep the information about applied catalog promotions on each
ChannelPricing. I propose to start simple, with an array of arrays 💃 to make it happen sooner than later. If we decide in the future we need some more sophisticated structure - we can always change it 🚀