[CatalogPromotions] Manage rules and actions from UI #13052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Sep 3, 2021
Zales0123
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Related tickets | based on #13048 |
| License | MIT |
Zales0123
changed the title
Zales0123
force-pushed
the
cp-rules-and-actions-ui
branch
from
7d66779
to
558cd11
Compare
GSadee
approved these changes
Sep 3, 2021
| /** | ||
| * @When /^it applies on variants ("[^"]+" variant) and ("[^"]+" variant)$/ | ||
| */ | ||
| public function itAppliesOnVariants(...$variants): void |
There was a problem hiding this comment.
Suggested change
| public function itAppliesOnVariants(...$variants): void | |
| public function itAppliesOnVariants(ProductVariantInterface ...$variants): void |
| /** | ||
| * @Then /^it should apply to ("[^"]+" variant) and ("[^"]+" variant)$/ | ||
| */ | ||
| public function itShouldHaveRule(ProductVariantInterface $firstVariant, ProductVariantInterface $secondVariant): void |
There was a problem hiding this comment.
Suggested change
| public function itShouldHaveRule(ProductVariantInterface $firstVariant, ProductVariantInterface $secondVariant): void | |
| public function itShouldApplyToVariants(ProductVariantInterface ...$variants): void |
and of course adjust the content of this method
|
Thank you, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.