[CatalogPromotions] Add fixtures for catalog promotions rules and actions #13055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Sep 3, 2021
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
AdamKasp
reviewed
Sep 3, 2021
src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/shop_configuration.yaml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/shop_configuration.yaml
Outdated
Show resolved
Hide resolved
GSadee
requested changes
Sep 3, 2021
src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/shop_configuration.yaml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Fixture/CatalogPromotionRuleFixture.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
add-fixtures-for-catalog-promotions-rule
branch
6 times, most recently
from
eee9d33
to
86e4765
Compare
GSadee
added
the
Enhancement
GSadee
reviewed
Sep 7, 2021
src/Sylius/Bundle/CoreBundle/Fixture/Factory/CatalogPromotionActionExampleFactory.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/app/fixtures/shop_configuration.yaml
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
add-fixtures-for-catalog-promotions-rule
branch
from
86e4765
to
d8ba350
Compare
GSadee
changed the title
GSadee
approved these changes
Sep 8, 2021
| $resolver | ||
| ->setDefault('type', CatalogPromotionActionInterface::TYPE_PERCENTAGE_DISCOUNT) | ||
| ->setAllowedTypes('type', 'string') | ||
| ->setDefault('configuration', []) |
There was a problem hiding this comment.
I would be for setting some amount as a default configuration because now, the default action in invalid
| $resolver | ||
| ->setDefault('type', CatalogPromotionRuleInterface::TYPE_FOR_VARIANTS) | ||
| ->setAllowedTypes('type', 'string') | ||
| ->setDefault('configuration', []) |
| actions: | ||
| - type: 'percentage_discount' | ||
| configuration: | ||
| - amount: 0.5 |
There was a problem hiding this comment.
Suggested change
| - amount: 0.5 | |
| amount: 0.5 |
|
Thank you, Tomasz! 🎉 |
GSadee
added a commit
that referenced
this pull request
Sep 9, 2021
…ns and rules (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #13055 | License | MIT <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 42371c8 [CatalogPromotion] Fix configuration of fixtures for actions and rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.