Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotion] refactor cp rule to be consistent with cp action #13066

Merged
merged 2 commits into from
Sep 8, 2021
Merged

[CatalogPromotion] refactor cp rule to be consistent with cp action #13066

merged 2 commits into from
Sep 8, 2021

Conversation

SirDomin
Copy link
Contributor

@SirDomin SirDomin commented Sep 7, 2021

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

@SirDomin SirDomin added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Sep 7, 2021
@SirDomin SirDomin requested a review from a team as a code owner September 7, 2021 09:34
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Sep 7, 2021
@SirDomin SirDomin mentioned this pull request Sep 7, 2021
Merged
GSadee
GSadee reviewed Sep 8, 2021
View reviewed changes
src/Sylius/Bundle/CoreBundle/Form/Type/CatalogRule/VariantRuleConfigurationType.php

declare(strict_types=1);

namespace Sylius\Bundle\CoreBundle\Form\Type\CatalogRule;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
namespace Sylius\Bundle\CoreBundle\Form\Type\CatalogRule;
namespace Sylius\Bundle\CoreBundle\Form\Type\CatalogPromotionRule;

src/Sylius/Bundle/CoreBundle/Form/Type/CatalogRule/VariantRuleConfigurationType.php
use Symfony\Component\Form\DataTransformerInterface;
use Symfony\Component\Form\FormBuilderInterface;

final class VariantRuleConfigurationType extends AbstractType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
final class VariantRuleConfigurationType extends AbstractType
final class ForVariantsRuleConfigurationType extends AbstractType

@GSadee GSadee merged commit 44c8307 into Sylius:master Sep 8, 2021
@GSadee
Copy link
Member

GSadee commented Sep 8, 2021

Thank you, @SirDomin! 🥇

@GSadee GSadee mentioned this pull request Sep 8, 2021
Merged
lchrusciel added a commit that referenced this pull request Sep 8, 2021
@lchrusciel
refactor #13072 [CatalogPromotion] Improve names and namespaces of ca…
05b2ff4 
…talog promotion rule form types (GSadee)

This PR was merged into the 1.11-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations?   | no
| Related tickets | after #13066 (review)
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

ba06dfe [CatalogPromotion] Improve names and namespaces of catalog promotion rule form types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel left review comments

@arti0090 arti0090 arti0090 approved these changes

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SirDomin @GSadee @lchrusciel @arti0090