Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix persisting of Catalog Promotion data on create #13067

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix persisting of Catalog Promotion data on create #13067

merged 1 commit into from
Sep 8, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Sep 7, 2021

Q A
Branch? master
Bug fix? kind of (fix bug for feature)
New feature? no
BC breaks? no
Deprecations? no
License MIT

@arti0090 arti0090 requested a review from a team as a code owner September 7, 2021 10:11
@GSadee GSadee added the Bug Confirmed bugs or bugfixes. label Sep 8, 2021
@arti0090 arti0090 force-pushed the what-happened-in-cp branch 2 times, most recently from c6fefd4 to a5689b7 Compare September 8, 2021 06:09
@lchrusciel
Copy link
Member

But there are still implementation of these steps:

        And there is a catalog promotion with "winter_sale" code and "Winter sale" name
        And it will be applied on "PHP T-Shirt" variant
        And it will reduce price by "50%"

In behat contexts. Do we want to keep them?

@lchrusciel lchrusciel merged commit 3c60865 into Sylius:master Sep 8, 2021
@lchrusciel
Copy link
Member

Thank you, @arti0090! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@SirDomin SirDomin SirDomin left review comments

@Tomanhez Tomanhez Tomanhez left review comments

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arti0090 @lchrusciel @GSadee @SirDomin @Tomanhez