Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] [Catalog Promotion] validate action amount #13082

Merged
merged 1 commit into from
Sep 10, 2021
Merged

[API] [Catalog Promotion] validate action amount #13082

merged 1 commit into from
Sep 10, 2021

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Sep 9, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner September 9, 2021 13:23
@AdamKasp AdamKasp force-pushed the add-only-float-validation-to-cp-action branch 3 times, most recently from d31a892 to b736937 Compare September 9, 2021 13:45
@GSadee GSadee added API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Sep 10, 2021
GSadee
GSadee reviewed Sep 10, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this case to the contract test: https://github.com/Sylius/Sylius/blob/master/tests/Api/Admin/CatalogPromotionsTest.php#L230

features/promotion/managing_catalog_promotions/validating_catalog_promotion_creation.feature Outdated Show resolved Hide resolved
src/Sylius/Bundle/PromotionBundle/Resources/translations/validators.en.yml Outdated Show resolved Hide resolved
src/Sylius/Bundle/PromotionBundle/Validator/CatalogPromotionActionValidator.php Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the add-only-float-validation-to-cp-action branch from b736937 to b20634e Compare September 10, 2021 07:25
@GSadee GSadee merged commit 6b2c84b into Sylius:master Sep 10, 2021
@GSadee
Copy link
Member

GSadee commented Sep 10, 2021

Thanks, Adam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamKasp @GSadee @arti0090