Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS]Add Catalog Promotion documentation #13084

Merged
merged 2 commits into from Sep 13, 2021
Merged

[DOCS]Add Catalog Promotion documentation #13084

merged 2 commits into from Sep 13, 2021

Conversation

arti0090
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@arti0090 arti0090 requested a review from a team as a code owner September 10, 2021 07:26
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 10, 2021
@arti0090 arti0090 changed the title [WIP][DOCS]Add Catalog Promotion documentation [DOCS]Add Catalog Promotion documentation Sep 10, 2021
AdamKasp
AdamKasp approved these changes Sep 10, 2021
View reviewed changes
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Show resolved Hide resolved
GSadee
GSadee approved these changes Sep 13, 2021
View reviewed changes
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
AdamKasp
AdamKasp approved these changes Sep 13, 2021
View reviewed changes
docs/book/products/catalog_promotions.rst Outdated Show resolved Hide resolved
@arti0090 arti0090 force-pushed the CP-docs branch 2 times, most recently from 89c9957 to 4a57246 Compare September 13, 2021 06:50
@SirDomin SirDomin merged commit 7a8b2c6 into Sylius:master Sep 13, 2021
@SirDomin
Copy link
Contributor

Thank you, @arti0090! 🎉

@arti0090 arti0090 mentioned this pull request Sep 13, 2021
Merged
CoderMaggie added a commit that referenced this pull request Sep 13, 2021
@CoderMaggie
bug #13096 [DOCS] Fix catalog promotions docs reference (arti0090)
0d1cdda 
This PR was merged into the 1.11-dev branch.

Discussion
----------

A quick fixup to docs references from #13084

before and after
![image](https://user-images.githubusercontent.com/35863747/133078815-1c393889-5c7e-44ba-83f3-b33b1da8cbba.png)



Commits
-------

a67fa86 [DOCS] Fix catalog promotions docs reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@SirDomin SirDomin SirDomin approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arti0090 @SirDomin @GSadee @AdamKasp