[CatalogPromotions] Add product to cart with discounted catalog price #13098
Conversation
Tomanhez
commented
Sep 14, 2021
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price
branch
2 times, most recently
from
d66e101
to
0a12ba1
Compare
features/cart/shopping_cart/adding_product_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
features/cart/shopping_cart/adding_product_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
...art/shopping_cart/adding_product_with_variants_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
...art/shopping_cart/adding_product_with_variants_with_discounted_catalog_price_to_cart.feature
Show resolved
Hide resolved
...art/shopping_cart/adding_product_with_variants_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
| When I view product "Wyborowa Vodka" | ||
| And I select "Wyborowa Apple" variant | ||
| Then the product variant price should be "$8,79" | ||
| And the product original price should be "$20.00" |
There was a problem hiding this comment.
I wonder, should we use price/original price words within the shop context. For a Customer/Visitor it's more like a discounted price/price, wdyt?
There was a problem hiding this comment.
IMO the most important thing here is still Price, and this is something that really bothers Mr. Customer. The way how we say what was the price before is not so important - does the customer cares if it was called original? I don't think so. And in this case I would think about API first - where we are returning original price 🎉
There was a problem hiding this comment.
Yes.... but! 😄 API-first is not an argument, as Behat scenarios are and should be always context-agnostic. What we should do in Behat scenarios is imitating the user behaviour. So, does the Customer sees the crossed-out price with a new one beside and thinks "the original price is X, but a price is now Y!"? Or it's more like "the price before was X, but a new, discounted price is Y!" 🚀 🐎
Of course, it's not a blocker for merge, but I believe we should really focus on Customer's behaviour and their vocabulary, to write perfect Behat scenarios :) 🖖
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price
branch
4 times, most recently
from
d2c416d
to
43b8fa1
Compare
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price
branch
from
43b8fa1
to
b77b125
Compare
...t/viewing_products/viewing_different_discounted_price_for_different_product_variants.feature
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
customer-add-product-with-discounted-catalog-price
branch
2 times, most recently
from
d22047b
to
2335186
Compare
...art/shopping_cart/adding_product_with_variants_with_discounted_catalog_price_to_cart.feature
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
customer-add-product-with-discounted-catalog-price
branch
from
2335186
to
5c748dc
Compare
|
Thank you, Tomasz and Artur! 🥇 |
