[CatalogPromotions] Showing catalog promotions in Products index and show page #13101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
reviewed
Sep 14, 2021
AdamKasp
reviewed
Sep 14, 2021
src/Sylius/Bundle/ShopBundle/Resources/views/Product/Show/_price.html.twig
Outdated
Show resolved
Hide resolved
SirDomin
force-pushed
the
behats-for-catalog-promotions
branch
from
61cd203
to
c2c7ac1
Compare
AdamKasp
approved these changes
Sep 14, 2021
GSadee
reviewed
Sep 15, 2021
...es/promotion/applying_catalog_promotions/seeing_applied_catalog_promotion_on_variant.feature
Outdated
Show resolved
Hide resolved
...otion/applying_catalog_promotions/seeing_applied_catalog_promotions_on_variants_list.feature
Outdated
Show resolved
Hide resolved
Zales0123
changed the title
GSadee
reviewed
Sep 15, 2021
...es/promotion/applying_catalog_promotions/seeing_applied_catalog_promotion_on_variant.feature
Outdated
Show resolved
Hide resolved
...otion/applying_catalog_promotions/seeing_applied_catalog_promotions_on_variants_list.feature
Show resolved
Hide resolved
...otion/applying_catalog_promotions/seeing_applied_catalog_promotions_on_variants_list.feature
Outdated
Show resolved
Hide resolved
Zales0123
changed the title
AdamKasp
approved these changes
Sep 15, 2021
|
Thank you, @SirDomin and @Zales0123 ! 🎉 |
GSadee
added a commit
that referenced
this pull request
Sep 16, 2021
…iption in label if not set (Zales0123) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | introduced in #13101 | License | MIT Before: <img width="588" alt="Zrzut ekranu 2021-09-16 o 08 59 13" src="https://user-images.githubusercontent.com/6212718/133565044-a6ff33f4-2236-4e50-b738-fc7c27e4f774.png"> After: <img width="607" alt="Zrzut ekranu 2021-09-16 o 08 57 03" src="https://user-images.githubusercontent.com/6212718/133565003-6b0c7c39-eafb-4724-8894-7b9daed531e6.png"> Commits ------- 4f23bb2 Do not display applied promotion description in label if not set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Products index:
Product's details: