Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Catalog Promotions] Reapplying Catalog Promotion on Action Edit #13105

Merged
merged 8 commits into from
Sep 22, 2021
Merged

[Catalog Promotions] Reapplying Catalog Promotion on Action Edit #13105

merged 8 commits into from
Sep 22, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Sep 14, 2021 •
edited
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@arti0090 arti0090 requested a review from a team as a code owner September 14, 2021 20:07
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Sep 15, 2021
@arti0090
Copy link
Contributor Author

No path for action 🎉

image

GSadee
GSadee reviewed Sep 20, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more scenarios to cover different behaviours, e.g.:

  • removing an existing action
  • adding a new action
  • removing an existing action and adding a new one

...n/applying_catalog_promotions/reapplying_catalog_promotions_after_editing_its_action.feature Outdated Show resolved Hide resolved
...n/applying_catalog_promotions/reapplying_catalog_promotions_after_editing_its_action.feature Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/CatalogPromotionAction.xml Outdated Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Swagger/PathHiderDocumentationNormalizer.php Show resolved Hide resolved
src/Sylius/Bundle/ApiBundle/Swagger/PathHiderDocumentationNormalizer.php Outdated Show resolved Hide resolved
@arti0090 arti0090 force-pushed the reapplying-promotion branch 4 times, most recently from 7cc6774 to 85d5dc7 Compare September 20, 2021 12:14
@arti0090 arti0090 force-pushed the reapplying-promotion branch 2 times, most recently from 4bd1e27 to bca8520 Compare September 21, 2021 08:49
GSadee
GSadee reviewed Sep 21, 2021
View reviewed changes
...on/applying_catalog_promotions/reapplying_catalog_promotions_after_adding_its_action.feature Outdated Show resolved Hide resolved
...on/applying_catalog_promotions/reapplying_catalog_promotions_after_adding_its_action.feature Outdated Show resolved Hide resolved
...on/applying_catalog_promotions/reapplying_catalog_promotions_after_adding_its_action.feature Outdated Show resolved Hide resolved
...n/applying_catalog_promotions/reapplying_catalog_promotions_after_editing_its_action.feature Outdated Show resolved Hide resolved
...n/applying_catalog_promotions/reapplying_catalog_promotions_after_editing_its_action.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php Outdated Show resolved Hide resolved
...on/applying_catalog_promotions/reapplying_catalog_promotions_after_adding_its_action.feature Outdated Show resolved Hide resolved
...n/applying_catalog_promotions/reapplying_catalog_promotions_after_editing_its_action.feature Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php Outdated Show resolved Hide resolved
src/Sylius/Behat/Context/Api/Admin/ManagingCatalogPromotionsContext.php Show resolved Hide resolved
@arti0090 arti0090 force-pushed the reapplying-promotion branch 3 times, most recently from b37f376 to c21f9a1 Compare September 21, 2021 14:12
@GSadee GSadee merged commit 431f985 into Sylius:master Sep 22, 2021
@GSadee
Copy link
Member

GSadee commented Sep 22, 2021

Thank you, @arti0090! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@lchrusciel lchrusciel lchrusciel left review comments

@GSadee GSadee GSadee approved these changes

@AdamKasp AdamKasp AdamKasp approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@arti0090 @GSadee @Zales0123 @lchrusciel @AdamKasp