[Api] Customer add product with discounted catalog price #13107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tomanhez
commented
Sep 14, 2021
Tomanhez
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
AdamKasp
reviewed
Sep 14, 2021
src/Sylius/Bundle/CoreBundle/Migrations/Version20210914180150.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Migrations/Version20210914180150.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Sep 15, 2021
src/Sylius/Component/Core/OrderProcessing/OrderPricesRecalculator.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price-api
branch
8 times, most recently
from
e62ea76
to
01cec54
Compare
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price-api
branch
from
01cec54
to
72ac7fe
Compare
GSadee
reviewed
Sep 15, 2021
...order_on_multi_channel/placing_an_order_on_multiple_channels_with_different_currency.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Serializer/OrderItemNormalizerSpec.php
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price-api
branch
from
ab2e727
to
44ebd4a
Compare
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price-api
branch
from
44ebd4a
to
a38a177
Compare
AdamKasp
reviewed
Sep 15, 2021
Comment on lines
9
to
15
| And the store has a "T-Shirt" configurable product | ||
| And this product has "PHP T-Shirt" variant priced at "$20" | ||
| And this product has "Kotlin T-Shirt" variant priced at "$400" | ||
| And the product "T-Shirt" has a "PHP T-Shirt" variant priced at "$20" | ||
| And the product "T-Shirt" has a "Kotlin T-Shirt" variant priced at "$400" | ||
| And the store has a "Keyboard" configurable product | ||
| And this product has "RGB Keyboard" variant priced at "$40" | ||
| And this product has "Pink Keyboard" variant priced at "$300" | ||
| And the product "Keyboard" has a "RGB Keyboard" variant priced at "$40" | ||
| And the product "Keyboard" has a "Pink Keyboard" variant priced at "$40" | ||
| And there is a catalog promotion "Winter sale" that reduces price by "25%" and applies on "PHP T-Shirt" variant |
There was a problem hiding this comment.
why did you changed it? imo with shared storage it looks better
There was a problem hiding this comment.
I had problems with ApiContexts
src/Sylius/Bundle/ApiBundle/Resources/config/serialization/OrderItem.xml
Outdated
Show resolved
Hide resolved
Tomanhez
force-pushed
the
customer-add-product-with-discounted-catalog-price-api
branch
from
8403a85
to
c1f90c6
Compare
SirDomin
approved these changes
Sep 15, 2021
GSadee
approved these changes
Sep 16, 2021
|
Thanks, Tomasz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.