New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Catalog Promotion] Cart catalog promotion becomes ineligible #13112
[Catalog Promotion] Cart catalog promotion becomes ineligible #13112
Conversation
AdamKasp
commented
Sep 15, 2021
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | no |
BC breaks? | no |
License | MIT |
…products in the cart
...summary/seeing_current_prices_of_products_after_catalog_promotion_becomes_ineligible.feature
Outdated
Show resolved
Hide resolved
Feature: Seeing current prices of products after catalog promotion becomes ineligible | ||
In order to buy products in its correct prices | ||
As a Customer | ||
I want to have products with its current prices in the cart |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to have products with their original prices in the cart
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the current sentence has more sense for me because in this scenarios I want to have a valid and current price, for customer, it is irrelevant if it is original or discounted (by different catalog promotion for example)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring that the price that Customer sees is always current for they :) but it's not relevant for know, I would only change its
to their
🖖
And I specified the billing address as "Ankh Morpork", "Frost Alley", "90210", "United States" for "Jon Snow" | ||
And I proceed through checkout process | ||
Then I should be on the checkout summary step | ||
And I should see product "T-Shirt" with unit price "$20.00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot we check it before the final stap? Even on the cart itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH yes we can :D, we need to run order Processor
after admin changed something so each step after addressing is valid, going through the entire checkout was easy in behat and also it checks what I want :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we could just update the cart? It's not a blocker for merge, but with all these steps it seems like it's necessary to go through the checkout to see the result. And there is in the cart
in the scenario's description 💃
6e707be
to
a285b53
Compare
a285b53
to
fd4886e
Compare
Thank you, Adam! 🎉 |