Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotions] Do not display applied promotion description in label if not set #13114

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[CatalogPromotions] Do not display applied promotion description in label if not set #13114

merged 1 commit into from
Sep 16, 2021

Conversation

Zales0123
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets introduced in #13101
License MIT

Before:

Zrzut ekranu 2021-09-16 o 08 59 13

After:

Zrzut ekranu 2021-09-16 o 08 57 03

@Zales0123 Zales0123 added UX Issues and PRs aimed at improving User eXperience. Bug Confirmed bugs or bugfixes. labels Sep 16, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner September 16, 2021 06:59
@probot-autolabeler probot-autolabeler bot added the Shop ShopBundle related issues and PRs. label Sep 16, 2021
@GSadee GSadee merged commit 45f6562 into Sylius:master Sep 16, 2021
@GSadee
Copy link
Member

GSadee commented Sep 16, 2021

Thanks, Mateusz! 🥇

@Zales0123 Zales0123 deleted the do-not-display-cp-description-in-label-if-not-set branch September 16, 2021 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
Bug Confirmed bugs or bugfixes. Shop ShopBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zales0123 @GSadee