Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API] Remove phoneNumber from Customer command and handler #13117

Merged
merged 1 commit into from Sep 17, 2021
Merged

[API] Remove phoneNumber from Customer command and handler #13117

merged 1 commit into from Sep 17, 2021

Conversation

lchrusciel
Copy link
Member

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no (kind of)
Deprecations? no
Related tickets
License MIT

@lchrusciel lchrusciel added API APIs related issues and PRs. Bug Confirmed bugs or bugfixes. labels Sep 16, 2021
@lchrusciel lchrusciel requested a review from a team as a code owner September 16, 2021 18:07
Zales0123
Zales0123 reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to explain in the PR description why we do that 💃

@lchrusciel
Copy link
Member Author

The phoneNumber field was never exposed via serialization, so it was never used from the API perspective. What is more, we do not have any behat scenario covering this value. As a result, it is dead code for me, thats why I'm proposing removal of it.

@Zales0123 Zales0123 merged commit 5c7cfa1 into Sylius:master Sep 17, 2021
@Zales0123
Copy link
Member

Thank you, Łukasz! 🎉

@lchrusciel lchrusciel deleted the customer-register branch September 17, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lchrusciel @Zales0123