[CatalogPromotions][API] Reapply promotions after action removal #13131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Sep 22, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
arti0090
force-pushed
the
recalculating-price-after-removing-cp-action
branch
2 times, most recently
from
b938056
to
ea1191b
Compare
arti0090
commented
Sep 22, 2021
src/Sylius/Bundle/CoreBundle/Processor/CatalogPromotionReprocessor.php
Outdated
Show resolved
Hide resolved
GSadee
reviewed
Sep 24, 2021
src/Sylius/Bundle/CoreBundle/EventListener/CatalogPromotionEventListener.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
recalculating-price-after-removing-cp-action
branch
3 times, most recently
from
927df53
to
f1e441f
Compare
arti0090
force-pushed
the
recalculating-price-after-removing-cp-action
branch
from
f1e441f
to
547f3b6
Compare
GSadee
reviewed
Sep 28, 2021
src/Sylius/Bundle/ApiBundle/EventSubscriber/CatalogPromotionEventSubscriber.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/CatalogPromotionReprocessorInterface.php
Outdated
Show resolved
Hide resolved
Zales0123
reviewed
Sep 28, 2021
...n/applying_catalog_promotions/reapplying_catalog_promotions_after_editing_its_action.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/CatalogPromotionReprocessor.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/CatalogPromotionReprocessor.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionReprocessorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/CatalogPromotionReprocessorSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/EventSubscriber/CatalogPromotionEventSubscriber.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
recalculating-price-after-removing-cp-action
branch
from
f2730cc
to
b607ae3
Compare
arti0090
force-pushed
the
recalculating-price-after-removing-cp-action
branch
from
b607ae3
to
7d8b2f1
Compare
GSadee
approved these changes
Sep 29, 2021
|
Thank you, @arti0090! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.