Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotions] Add behats for CatalogPromotions based on taxon #13137

Merged
merged 2 commits into from
Sep 29, 2021
Merged

[CatalogPromotions] Add behats for CatalogPromotions based on taxon #13137

merged 2 commits into from
Sep 29, 2021

Conversation

Tomanhez
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

@Tomanhez Tomanhez requested a review from a team as a code owner September 23, 2021 10:29
AdamKasp
AdamKasp reviewed Sep 23, 2021
View reviewed changes
features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Show resolved Hide resolved
features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Show resolved Hide resolved
...ures/promotion/applying_catalog_promotions/seeing_applied_catalog_promotion_on_taxon.feature Outdated Show resolved Hide resolved
@AdamKasp
Copy link
Contributor

And I am not sure but do we need an extra scenario for applying promotion on product from child taxon (promo on men taxon with t-shirts child taxon)

@Tomanhez Tomanhez force-pushed the behats-for-taxon-based-cp-rule branch from cc222e4 to 59f5df2 Compare September 23, 2021 11:38
@GSadee GSadee added Behat Issues and PRs aimed at improving Behat usage. Feature New feature proposals. labels Sep 24, 2021
GSadee
GSadee reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@GSadee GSadee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are missing scenarios for managing new rule:

  • creating
  • editing
  • validating

features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Outdated Show resolved Hide resolved
features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Show resolved Hide resolved
features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
@Tomanhez Tomanhez force-pushed the behats-for-taxon-based-cp-rule branch from 59f5df2 to 00cc462 Compare September 24, 2021 11:54
@Tomanhez Tomanhez force-pushed the behats-for-taxon-based-cp-rule branch from 00cc462 to 79d9803 Compare September 27, 2021 09:30
Zales0123
Zales0123 reviewed Sep 28, 2021
View reviewed changes
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Outdated Show resolved Hide resolved
...romotion/applying_catalog_promotions/applying_all_available_types_catalog_promotions.feature Show resolved Hide resolved
features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Outdated Show resolved Hide resolved
features/promotion/applying_catalog_promotions/applying_catalog_promotions_for_taxon.feature Show resolved Hide resolved
...ures/promotion/applying_catalog_promotions/seeing_applied_catalog_promotion_on_taxon.feature Outdated Show resolved Hide resolved
features/promotion/managing_catalog_promotions/creating_catalog_promotion.feature Outdated Show resolved Hide resolved
features/promotion/managing_catalog_promotions/editing_catalog_promotion.feature Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the behats-for-taxon-based-cp-rule branch 2 times, most recently from 1921843 to 42cde3c Compare September 29, 2021 10:16
@AdamKasp AdamKasp force-pushed the behats-for-taxon-based-cp-rule branch from 42cde3c to 257a984 Compare September 29, 2021 10:50
@Zales0123 Zales0123 mentioned this pull request Sep 29, 2021
Merged
@AdamKasp AdamKasp force-pushed the behats-for-taxon-based-cp-rule branch from 257a984 to 567c551 Compare September 29, 2021 11:40
@Zales0123 Zales0123 merged commit c183192 into Sylius:master Sep 29, 2021
@Zales0123
Copy link
Member

Zales0123 commented Sep 29, 2021 •
edited
Loading

Thank you, Tomasz and Adam! 🥇

AdamKasp added a commit that referenced this pull request Sep 29, 2021
@AdamKasp
feature #13146 [Api] CatalogPromotionRule per taxon (AdamKasp, Tomanh…
b4ab49e 
…ez, Zales0123)

This PR was merged into the 1.11-dev branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | no
| New feature?    | yes
| BC breaks?      | no
| Deprecations?   | no
| License         | MIT

Based on #13137

<!--
 - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible)
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

dee928a Fixes to behats scenarios
a9076cb Fixes to behats scenarios
f01d694 Add behat implementation
43d680c Fix for validator
c9df0f9 Modify variant provider
51851fb Fixes in Behats
737546f Configure variants provider for "for_taxons" rule
20aabe7 Fix rules validation
c75e34b Enhance validation to check non existing taxons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee left review comments

@AdamKasp AdamKasp AdamKasp left review comments

@Zales0123 Zales0123 Zales0123 approved these changes

Assignees
No one assigned
Labels
Behat Issues and PRs aimed at improving Behat usage. Feature New feature proposals.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Tomanhez @AdamKasp @Zales0123 @GSadee