Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Fix admin path in swagger #13147

Merged
merged 1 commit into from Sep 28, 2021

Conversation

arti0090
Copy link
Contributor

@arti0090 arti0090 commented Sep 28, 2021

Q A
Branch? master
Bug fix? yes
New feature?
BC breaks? no
Deprecations? no
License MIT

The great comeback of admin authentication route 馃帀
image
馃帀

@arti0090 arti0090 requested a review from a team as a code owner September 28, 2021 09:02
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Sep 28, 2021
@arti0090 arti0090 added the Bug Confirmed bugs or bugfixes. label Sep 28, 2021
@@ -35,7 +35,7 @@ public function supportsNormalization($data, $format = null): bool
public function normalize($object, $format = null, array $context = [])
{
$docs = $this->decoratedNormalizer->normalize($object, $format, $context);
$paths = $docs['paths']->getArrayCopy();
$paths = (array) $docs['paths'];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this is a potential bugfix. If the decoration priority is set to different number, the $docs sometimes can be a normal array (not ArrayObject), in this case getArrayCopy() throws error, but (array) does the same and does not make any issue.

@Zales0123 Zales0123 merged commit 677855e into Sylius:master Sep 28, 2021
@Zales0123
Copy link
Member

Thank you, @arti0090! 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Bug Confirmed bugs or bugfixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants