Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotion] change change channel with toggle in UI #13156

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[CatalogPromotion] change change channel with toggle in UI #13156

merged 1 commit into from
Sep 30, 2021

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Sep 30, 2021 •
edited by Zales0123
Loading

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

Screenshot 2021-09-30 at 08 42 01

@AdamKasp AdamKasp requested a review from a team as a code owner September 30, 2021 06:44
@probot-autolabeler probot-autolabeler bot added the Admin AdminBundle related issues and PRs. label Sep 30, 2021
Zales0123
Zales0123 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the most ambitious change I've seen here for a long, long time 😄 🕐

arti0090
arti0090 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@arti0090 arti0090 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Development Seniority++

@GSadee GSadee merged commit 55c84d8 into Sylius:master Sep 30, 2021
@GSadee
Copy link
Member

GSadee commented Sep 30, 2021

Thank you, Adam! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@arti0090 arti0090 arti0090 approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AdamKasp @GSadee @Zales0123 @arti0090