[CatalogPromotions] Rename CP Rule to Scope #13161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
Admin
arti0090
force-pushed
the
rename-cp-rule-to-scope
branch
9 times, most recently
from
746570f
to
d139d6e
Compare
AdamKasp
approved these changes
Oct 1, 2021
src/Sylius/Bundle/CoreBundle/Migrations/Version20211001073918.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
rename-cp-rule-to-scope
branch
from
d139d6e
to
b58e7d2
Compare
AdamKasp
reviewed
Oct 1, 2021
src/Sylius/Bundle/PromotionBundle/Form/Type/CatalogPromotionType.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Form/Type/CatalogPromotionType.php
Outdated
Show resolved
Hide resolved
arti0090
force-pushed
the
rename-cp-rule-to-scope
branch
from
b58e7d2
to
821247f
Compare
GSadee
approved these changes
Oct 4, 2021
| @@ -1,8 +1,8 @@ | |||
| @applying_catalog_promotions | |||
There was a problem hiding this comment.
You should also change the name of filename
|
Thanks, @arti0090! 🎉 |
Zales0123
added a commit
that referenced
this pull request
Oct 5, 2021
…ope (GSadee) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #13161 | License | MIT Before:  After:  <!-- - Bug fixes must be submitted against the 1.9 or 1.10 branch (the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 8294a4e [CatalogPromotion] Minor fixes after renaming rule to scope
GSadee
added a commit
that referenced
this pull request
Oct 5, 2021
…n (arti0090) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT Fixing last comment from #13161 Commits ------- c49a487 Rename scope behat file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Catalog Promotion Rule is now renamed to Scope - this naming was good in the case of Cart Promotion (which was the inspiration for this Rule) but it looks like the Rule is not an appropriate naming. Thus the decision to rename to scope 🚀