Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX][Attribute] Use single_text widget for Date&DateTime attribute form type #13163

Merged
merged 1 commit into from
Jul 19, 2022
Merged

[UX][Attribute] Use single_text widget for Date&DateTime attribute form type #13163

merged 1 commit into from
Jul 19, 2022

Conversation

Jibbarth
Copy link
Contributor

@Jibbarth Jibbarth commented Oct 3, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets N/A
License MIT

Hi 👋

I notice that Date and DateTime attribute use the default render on Product attribute tabs:

image

This PR change this to use the great single_text rendering, combined with semantic-ui:

image

I think it would provide a better User Experience to have unified display for date/datetime in the Admin.

I targetted master branch cause it could be considered as a new feature, but I can change to 1.10 if needed.

WDYT ?

@Jibbarth Jibbarth requested a review from a team as a code owner October 3, 2021 09:47
@Jibbarth Jibbarth changed the title [UX][Attribute] Use single_text widget for Date &DateTime attribute form type [UX][Attribute] Use single_text widget for Date&DateTime attribute form type Oct 3, 2021
@Zales0123 Zales0123 added Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience. labels Oct 5, 2021
vvasiloi
vvasiloi approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@vvasiloi vvasiloi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you, @Jibbarth!

@lchrusciel lchrusciel closed this Jul 19, 2022
@lchrusciel lchrusciel reopened this Jul 19, 2022
@lchrusciel lchrusciel merged commit 4b0ebb9 into Sylius:1.12 Jul 19, 2022
@lchrusciel
Copy link
Member

Hey Jibe,

thanks a lot for your proposal! It is finally merged :) 🎉

@Jibbarth Jibbarth deleted the feature/improve-date-attribute-widget branch July 19, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lchrusciel lchrusciel lchrusciel approved these changes

@vvasiloi vvasiloi vvasiloi approved these changes

Assignees
No one assigned
Labels
Admin AdminBundle related issues and PRs. UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jibbarth @lchrusciel @vvasiloi @Zales0123