[CatalogPromotions] Start and end date #13179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zales0123
force-pushed
the
add-start-and-end-date-to-catalog-promotion
branch
from
c8adc95
to
1c5d8c6
Compare
GSadee
approved these changes
Oct 8, 2021
|
Thanks, Mateusz! 🥇 |
GSadee
added a commit
that referenced
this pull request
Oct 11, 2021
…processing (Zales0123) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Related tickets | | License | MIT Based on the work from [this PR](#13179), we can start taking into account catalog promotion dates during their processing. Initially, I assumed that all `CatalogPromotionInterface $catalogPromotion` arguments passed to `CatalogPromotionProcessor::process` will be already eligible (as we only use this processor in the `AllCatalogPromotionsProcessor` service. If in the future, we will need filtration other than on CPs collection (e.g. on a single catalog promotion), we can extend the filter's functionality 🖖 Note: I wanted to use a calendar service that is already used in Behat... but it's implemented in the ShippingBundle 💃 probably we would need to extract it somewhere to make it available for all other date-/time-based functionalities. Commits ------- 376e496 [Behat] Describe CP time ranges with Behat scenarios b0035a0 Create Catalog Promotions provider and use it c98ae01 First version of iterable criterias for CPs cb1deb9 Implement DateRange criteria for CatalogPromotions filtration d328e8f Change Criteria to operate on QueryBuilder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step for delayed Catalog Promotions processing 🚀
API:
UI:
