[DOCS][Catalog Promotions] Making new CP scope #13183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arti0090
commented
Oct 8, 2021
arti0090
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
the
Documentation
arti0090
changed the title
GSadee
reviewed
Oct 8, 2021
docs/cookbook/catalog-promotions/custom-catalog-promotion-scope.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/catalog-promotions/custom-catalog-promotion-scope.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/catalog-promotions/custom-catalog-promotion-scope.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/catalog-promotions/custom-catalog-promotion-scope.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/catalog-promotions/custom-catalog-promotion-scope.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/catalog-promotions/custom-catalog-promotion-scope.rst
Outdated
Show resolved
Hide resolved
CoderMaggie
reviewed
Oct 10, 2021
arti0090
force-pushed
the
docs-new-cp-scope
branch
from
f24a490
to
1990704
Compare
arti0090
force-pushed
the
docs-new-cp-scope
branch
2 times, most recently
from
9c73ac5
to
007cb5d
Compare
arti0090
changed the title
arti0090
force-pushed
the
docs-new-cp-scope
branch
from
007cb5d
to
5096543
Compare
GSadee
approved these changes
Oct 11, 2021
Comment on lines
75
to
76
| promotions/custom-promotion-rule | ||
| promotions/custom-promotion-action |
There was a problem hiding this comment.
These two docs could be refactored to custom-cart-promotion-*
There was a problem hiding this comment.
I will do it in another PR 🚀
arti0090
force-pushed
the
docs-new-cp-scope
branch
from
5096543
to
719e5ab
Compare
GSadee
approved these changes
Oct 11, 2021
|
Thank you, @arti0090! 🥇 |
GSadee
added a commit
that referenced
this pull request
Oct 12, 2021
…i0090) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | License | MIT #13183 (comment) Commits ------- 87ef7fd Refactor docs from promotion to cart promotion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.