Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue/12985-migration-in-corebundle #13187

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

hasukmistry
Copy link

@hasukmistry hasukmistry commented Oct 8, 2021

Updates migration file

Q A
Branch? 1.11
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets #12985
License MIT

@coldic3 coldic3 force-pushed the issue/12985-migration-in-corebundle branch from 6615d77 to fc9c9ff Compare November 14, 2022 09:43
@coldic3 coldic3 changed the base branch from 1.12 to 1.11 November 14, 2022 09:47
@coldic3
Copy link
Contributor

coldic3 commented Nov 14, 2022

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "issue/12985-migration-in-corebundle" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@coldic3
Copy link
Contributor

coldic3 commented Nov 14, 2022

Hey @hasukmistry,
thanks a lot for the PR! I've added a few additional changes and removed Sylius\Component\Addressing\Model\Scope from migrations to operate just on raw queries without any dependencies to the code base itself.

@GSadee GSadee added the DX Issues and PRs aimed at improving Developer eXperience. label Nov 16, 2022
@GSadee GSadee merged commit 7f45d53 into Sylius:1.11 Nov 16, 2022
@GSadee
Copy link
Member

GSadee commented Nov 16, 2022

Thanks, Hasmukh! 🥇

coldic3 added a commit that referenced this pull request Nov 16, 2022
…n (GSadee)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A                                                            |
|-----------------|--------------------------------------------------------------|
| Branch?         | 1.11|
| Bug fix?        | yes                                                       |
| New feature?    | no                                                       |
| BC breaks?      | no                                                       |
| Deprecations?   | no|
| Related tickets | after #13187 |
| License         | MIT                                                          |

<!--
 - Bug fixes must be submitted against the 1.11 or 1.12 branch
 - Features and deprecations must be submitted against the 1.13 branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

fb6d018 [Migrations] Remove usage of non existent AbstractMigration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants