Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CatalogPromotion] dates are editable and validated #13256

Merged
merged 4 commits into from Nov 8, 2021
Merged

[CatalogPromotion] dates are editable and validated #13256

merged 4 commits into from Nov 8, 2021

Conversation

AdamKasp
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

@AdamKasp AdamKasp requested a review from a team as a code owner October 28, 2021 08:40
@probot-autolabeler probot-autolabeler bot added the API APIs related issues and PRs. label Oct 28, 2021
@AdamKasp AdamKasp force-pushed the basic-validation-for-CP-dates branch 3 times, most recently from c7d84fe to ffe206c Compare October 29, 2021 08:17
@AdamKasp AdamKasp force-pushed the basic-validation-for-CP-dates branch 3 times, most recently from bcfaf79 to 1591274 Compare November 1, 2021 12:01
@AdamKasp AdamKasp force-pushed the basic-validation-for-CP-dates branch from 1591274 to c30820f Compare November 3, 2021 11:05
@GSadee GSadee merged commit 30b6809 into Sylius:master Nov 8, 2021
@GSadee
Copy link
Member

GSadee commented Nov 8, 2021

Thanks, Adam! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zales0123 Zales0123 Zales0123 left review comments

@GSadee GSadee GSadee approved these changes

Assignees
No one assigned
Labels
API APIs related issues and PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AdamKasp @GSadee @Zales0123