-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CatalogPromotions] Add priorities #13260
Merged
AdamKasp
merged 8 commits into
Sylius:master
from
Zales0123:prioritize-catalog-promotions
Nov 12, 2021
Merged
[CatalogPromotions] Add priorities #13260
AdamKasp
merged 8 commits into
Sylius:master
from
Zales0123:prioritize-catalog-promotions
Nov 12, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
approved these changes
Oct 29, 2021
9ef0495
to
26ad4ab
Compare
SirDomin
approved these changes
Nov 2, 2021
26ad4ab
to
f8b3335
Compare
GSadee
approved these changes
Nov 3, 2021
f8b3335
to
6ae4323
Compare
a14d84b
to
c3b6075
Compare
227409f
to
983bffa
Compare
90f38ec
to
260d4b1
Compare
4f2a231
to
1c7c0a5
Compare
Thank you, Mateusz! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar concept to the one we have on cart promotions. Catalog promotions are always applied based on their priority (descending order). The default priority is
0
.It does not affect discount calculations for now, as we have only the percentage-based type of action, but would be useful in the future 🖖
API:
Form:
Details:
Index: