Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CatalogPromotions] Add priorities #13260

Merged
merged 8 commits into from
Nov 12, 2021

Conversation

Zales0123
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
License MIT

Similar concept to the one we have on cart promotions. Catalog promotions are always applied based on their priority (descending order). The default priority is 0.

It does not affect discount calculations for now, as we have only the percentage-based type of action, but would be useful in the future 🖖

API:

Zrzut ekranu 2021-10-29 o 13 04 10

Form:

Zrzut ekranu 2021-10-29 o 13 03 14

Details:

Zrzut ekranu 2021-10-29 o 13 03 32

Index:

Zrzut ekranu 2021-10-29 o 13 02 50

@Zales0123 Zales0123 added the Feature New feature proposals. label Oct 29, 2021
@Zales0123 Zales0123 requested a review from a team as a code owner October 29, 2021 11:06
@probot-autolabeler probot-autolabeler bot added Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Shop ShopBundle related issues and PRs. labels Oct 29, 2021
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Oct 29, 2021
@Zales0123 Zales0123 force-pushed the prioritize-catalog-promotions branch from 9ef0495 to 26ad4ab Compare October 29, 2021 14:33
@AdamKasp AdamKasp force-pushed the prioritize-catalog-promotions branch from 26ad4ab to f8b3335 Compare November 3, 2021 07:16
src/Sylius/Behat/Page/Shop/Product/ShowPage.php Outdated Show resolved Hide resolved
@AdamKasp AdamKasp force-pushed the prioritize-catalog-promotions branch from f8b3335 to 6ae4323 Compare November 4, 2021 07:58
@CoderMaggie CoderMaggie removed the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Nov 5, 2021
@AdamKasp AdamKasp force-pushed the prioritize-catalog-promotions branch 2 times, most recently from a14d84b to c3b6075 Compare November 5, 2021 09:52
@GSadee GSadee force-pushed the prioritize-catalog-promotions branch 4 times, most recently from 227409f to 983bffa Compare November 9, 2021 06:57
@GSadee GSadee force-pushed the prioritize-catalog-promotions branch from 90f38ec to 260d4b1 Compare November 9, 2021 12:41
@GSadee GSadee force-pushed the prioritize-catalog-promotions branch from 4f2a231 to 1c7c0a5 Compare November 10, 2021 05:46
@AdamKasp AdamKasp merged commit b66a105 into Sylius:master Nov 12, 2021
@AdamKasp
Copy link
Contributor

Thank you, Mateusz! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin AdminBundle related issues and PRs. API APIs related issues and PRs. Feature New feature proposals. Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants