[CatalogPromotion] Add exclusiveness flag #13303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AdamKasp
commented
Nov 18, 2021
AdamKasp
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| License | MIT |
AdamKasp
force-pushed
the
add-exclusivness-of-catalog-promotion-v3
branch
2 times, most recently
from
84eb3a6
to
31ca767
Compare
probot-autolabeler
bot
added
the
Documentation
AdamKasp
force-pushed
the
add-exclusivness-of-catalog-promotion-v3
branch
2 times, most recently
from
131bdf0
to
1c4915c
Compare
GSadee
reviewed
Nov 18, 2021
...ures/promotion/applying_catalog_promotions/applying_only_exclusive_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/doctrine/model/ChannelPricing.orm.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Doctrine/ORM/CatalogPromotionRepository.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/PromotionBundle/Resources/config/doctrine/model/CatalogPromotion.orm.xml
Outdated
Show resolved
Hide resolved
Zales0123
reviewed
Nov 18, 2021
...ures/promotion/applying_catalog_promotions/applying_only_exclusive_catalog_promotion.feature
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Applicator/CatalogPromotionApplicator.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
add-exclusivness-of-catalog-promotion-v3
branch
from
347e40e
to
0b50104
Compare
AdamKasp
force-pushed
the
add-exclusivness-of-catalog-promotion-v3
branch
6 times, most recently
from
d8ed706
to
4bda9bd
Compare
GSadee
reviewed
Nov 24, 2021
src/Sylius/Bundle/CoreBundle/Migrations/Version20211122104644.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Formatter/AppliedPromotionInformationFormatter.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
add-exclusivness-of-catalog-promotion-v3
branch
from
4bda9bd
to
9d78dca
Compare
GSadee
approved these changes
Nov 25, 2021
Comment on lines
+146
to
+151
| if (reset($this->appliedPromotions)['is_exclusive']) | ||
| { | ||
| return true; | ||
| } | ||
|
|
||
| return false; |
There was a problem hiding this comment.
Suggested change
| if (reset($this->appliedPromotions)['is_exclusive']) | |
| { | |
| return true; | |
| } | |
| return false; | |
| return reset($this->appliedPromotions)['is_exclusive']); |
|
Thanks, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.