Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections for adding a field to the response #13310

Merged
merged 1 commit into from Dec 6, 2021
Merged

Conversation

j92
Copy link
Contributor

@j92 j92 commented Nov 19, 2021

I was implementing my own ProductNormalizer and found some issues in the docs:

  1. The example used the NormalizerAwareTrait, but for autowiring constructor injection might be easier.
  2. It was not clear in the example which service I had to inject for the normalizer, turns out it was @api_platform.serializer.normalizer.item
  3. The example referenced a defaultProductVariantResolver, but that property did not exist, so I added it.
Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
License MIT

I was implementing my own ProductNormalizer and found some issues in the docs:

1. The example used the NormalizerAwareTrait, but for autowiring constructor injection might be easier.
2. It was not clear in the example which service I had to inject for the normalizer, turns out it was `@api_platform.serializer.normalizer.item`
3. The example referenced a `defaultProductVariantResolver`, but that property did not exist, so I added it.
@j92 j92 requested a review from a team as a code owner November 19, 2021 14:57
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Nov 19, 2021
@Zales0123 Zales0123 merged commit cf6b2dc into Sylius:1.10 Dec 6, 2021
@Zales0123
Copy link
Member

Thanks, Joost! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants