Addressing, locale update and apply coupon code unified to one endpoint #13329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paullla
commented
Nov 24, 2021
paullla
commented
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | yes |
| Related tickets | |
| License | MIT |
paullla
changed the title
paullla
force-pushed
the
put_order
branch
3 times, most recently
from
7454205
to
a8137d0
Compare
lchrusciel
reviewed
Nov 29, 2021
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/UpdateCartHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/UpdateCartHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/Modifier/OrderAddressModifierInterface.php
Outdated
Show resolved
Hide resolved
| <attribute name="messenger">input</attribute> | ||
| <attribute name="input">Sylius\Bundle\ApiBundle\Command\Cart\ApplyCouponToCart</attribute> | ||
| <attribute name="denormalization_context"> | ||
| <attribute name="groups">shop:cart:apply_coupon</attribute> |
There was a problem hiding this comment.
Can we remove this denormalization context from serialization config?
src/Sylius/Bundle/ApiBundle/Resources/config/api_resources/Order.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/Assigner/OrderPromoCodeAssignerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/ApiBundle/spec/CommandHandler/Checkout/UpdateCartHandlerSpec.php
Show resolved
Hide resolved
paullla
force-pushed
the
put_order
branch
3 times, most recently
from
92278d0
to
ceb5e96
Compare
probot-autolabeler
bot
added
the
Maintenance
lchrusciel
reviewed
Dec 1, 2021
src/Sylius/Bundle/ApiBundle/CommandHandler/Checkout/UpdateCartHandler.php
Outdated
Show resolved
Hide resolved
paullla
force-pushed
the
put_order
branch
3 times, most recently
from
bc3bbd5
to
5c7df3e
Compare
lchrusciel
approved these changes
Dec 1, 2021
|
|
||
| /** @psalm-immutable */ | ||
| public ?AddressInterface $shippingAddress = null; | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** @psalm-immutable */ |
|
Thanks, Paula! 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.