Add Symfony 5.4 support for Sylius 1.10 #13357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
added
Maintenance
probot-autolabeler
bot
added
Admin
lchrusciel
force-pushed
the
symfony-5-4
branch
from
1b47c86
to
b8b7e8d
Compare
stloyd
reviewed
Dec 6, 2021
stloyd
reviewed
Dec 6, 2021
lchrusciel
force-pushed
the
symfony-5-4
branch
2 times, most recently
from
ccb9b7b
to
0de30b9
Compare
This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? |yes | BC breaks? | no | Deprecations? | no | License | MIT <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 28a02a6 Prepare Sylius for support Symfony 5.4 d2c39e4 remove usage of symfony internal method fef6243 bump symofny verion from 5.4.0-RC1 to 5.4 6339528 update argument in UsernamePasswordToken 2964e0e make workorounds over deprecated method in symofny 5.4
lchrusciel
force-pushed
the
symfony-5-4
branch
from
0de30b9
to
71e4fd6
Compare
lchrusciel
force-pushed
the
symfony-5-4
branch
from
64762f4
to
860399f
Compare
AdamKasp
approved these changes
Dec 6, 2021
Zales0123
approved these changes
Dec 6, 2021
lchrusciel
force-pushed
the
symfony-5-4
branch
5 times, most recently
from
4462110
to
5937ebb
Compare
|
Thanks, Łukasz! 🎉 |
This was referenced Dec 7, 2021
Zales0123
added a commit
that referenced
this pull request
Dec 13, 2021
This PR was merged into the 1.10 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.10 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | Leftover from #13357 and #13358 | License | MIT <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- e3ba9b9 [Docs] Add missing references in CONFLICT.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's bring Sf5.4 support to Sylius 1.10. This way, current users will benefit from Symfony 5.4 with current installations. I'm considering it as a bug-fix, as it is already possible to install this version according to our composer.json. What is more, it will make it possible to migrate first to Sf5.4 and then upgrade to Sylius 1.11.