New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Command] add command to generate jwt #13369
Conversation
SirDomin
commented
Dec 8, 2021
Q | A |
---|---|
Branch? | master |
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Deprecations? | no |
Related tickets | |
License | MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea 👌 But why not put it on 1.10
? I would see it as an improvement to our installation process, not an entirely new feature 🖖 🚀
src/Sylius/Bundle/CoreBundle/Command/JwtConfigurationCommand.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Command/JwtConfigurationCommand.php
Outdated
Show resolved
Hide resolved
use Symfony\Component\Console\Output\OutputInterface; | ||
use Symfony\Component\Console\Question\ConfirmationQuestion; | ||
|
||
final class JwtConfigurationCommand extends AbstractInstallCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be consistent with other command:
final class JwtConfigurationCommand extends AbstractInstallCommand | |
final class SetupJwtTokenCommand extends AbstractInstallCommand |
or
final class JwtConfigurationCommand extends AbstractInstallCommand | |
final class ConfigureJwtTokenCommand extends AbstractInstallCommand |
Thanks, @SirDomin! 🎉 |