Remove ORM 2.10 conflict #13372
Merged
Remove ORM 2.10 conflict #13372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
Maintenance
lchrusciel
approved these changes
Dec 9, 2021
|
Thanks, Michael! 🥇 |
2.4 isn't supported at all anymore and explicitly blocks PHP 8, so if you're going to bump this requirement then you should drop 2.4 support in full. |
|
makes sense, as Sylius is ^8.0 already. Can you open a PR? Will be part of next release. |
lchrusciel
added a commit
that referenced
this pull request
Dec 10, 2021
…rsions (mbabker) This PR was merged into the 1.11-dev branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Related tickets | mentioned in #13372 | License | MIT The 2.x branch of `gedmo/doctrine-extensions` is no longer supported and isn't installable on PHP 8. 3.2 is set as the minimum to avoid allowing 3.0 or 3.1 to be installed with incompatible ORM versions. Commits ------- b33618a Drop support for older `gedmo/doctrine-extensions` versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conflict against
doctrine/orm:^2.10has been unnecessary since thegedmo/doctrine-extensions3.2 release. In fact, the actual conflict was between the extensions package and the ORM, Sylius was never directly conflicted against it. Now that newer versions of the extensions package either have the appropriate conflict or fixed the conflict and now require newer ORM versions, Sylius no longer needs to have this conflict.