Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Catalog promotion label customization #13386

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

AdamKasp
Copy link
Contributor

@AdamKasp AdamKasp commented Dec 14, 2021

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
License MIT

should be merged after https://github.com/Sylius/Sylius/pull/13389/files

Screenshot 2021-12-14 at 08 49 26

Screenshot 2021-12-14 at 08 49 34

Screenshot 2021-12-14 at 08 49 37

@AdamKasp AdamKasp requested a review from a team as a code owner December 14, 2021 07:49
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Dec 14, 2021
Copy link
Member

@Zales0123 Zales0123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we need to override so much code just to customize the label... it seems that something is wrong :( Maybe we can extract some template and make it simpler and more generic?

Copy link
Member

@CoderMaggie CoderMaggie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's maybe rename the file to be simply:
docs/cookbook/promotions/catalog-promotion-labels.rst

@AdamKasp AdamKasp force-pushed the catalog-promotion-label-customization branch from cb845b9 to 93a0315 Compare December 15, 2021 10:17
GSadee added a commit that referenced this pull request Dec 15, 2021
…amKasp)

This PR was merged into the 1.11 branch.

Discussion
----------

| Q               | A
| --------------- | -----
| Branch?         | master
| Bug fix?        | yes
| New feature?    | no
| BC breaks?      | no/
| Related tickets | #13386 - this doc will be modified after this merge
| License         | MIT

to make customization easier we want to move catalog promotion labels to separate file
<!--
 - Bug fixes must be submitted against the 1.10 branch
 - Features and deprecations must be submitted against the master branch
 - Make sure that the correct base branch is set

 To be sure you are not breaking any Backward Compatibilities, check the documentation:
 https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->


Commits
-------

b44b544 move catalog promotion label to separate twig
@AdamKasp AdamKasp force-pushed the catalog-promotion-label-customization branch 2 times, most recently from 5f2c9c1 to 356e685 Compare December 15, 2021 10:39
@CoderMaggie CoderMaggie self-requested a review December 15, 2021 12:38
@AdamKasp AdamKasp force-pushed the catalog-promotion-label-customization branch 2 times, most recently from a23f2cc to a1e5ae5 Compare December 16, 2021 10:28
@GSadee GSadee changed the base branch from master to 1.11 December 16, 2021 10:31
@GSadee GSadee force-pushed the catalog-promotion-label-customization branch from a1e5ae5 to a03f54f Compare December 16, 2021 10:31
@GSadee
Copy link
Member

GSadee commented Dec 16, 2021

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "catalog-promotion-label-customization" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@GSadee GSadee merged commit 9453d7e into Sylius:1.11 Dec 16, 2021
@GSadee
Copy link
Member

GSadee commented Dec 16, 2021

Thanks, Adam! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants