-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Catalog promotion label customization #13386
[Docs] Catalog promotion label customization #13386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need to override so much code just to customize the label... it seems that something is wrong :( Maybe we can extract some template and make it simpler and more generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's maybe rename the file to be simply:
docs/cookbook/promotions/catalog-promotion-labels.rst
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
cb845b9
to
93a0315
Compare
…amKasp) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no/ | Related tickets | #13386 - this doc will be modified after this merge | License | MIT to make customization easier we want to move catalog promotion labels to separate file <!-- - Bug fixes must be submitted against the 1.10 branch - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- b44b544 move catalog promotion label to separate twig
docs/cookbook/promotions/customize-catalog-promotion-labels.rst
Outdated
Show resolved
Hide resolved
5f2c9c1
to
356e685
Compare
a23f2cc
to
a1e5ae5
Compare
a1e5ae5
to
a03f54f
Compare
The base of this pull-request was changed, you need fetch and reset your local branch Unless you added new commits (to this branch) locally that you did not push yet, Feel free to ask for assistance when you get stuck 👍 |
Thanks, Adam! 🎉 |
should be merged after https://github.com/Sylius/Sylius/pull/13389/files