Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use loadUserByIdentifier() since Symfony 5.3 #13394

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

kayue
Copy link
Contributor

@kayue kayue commented Dec 15, 2021

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Since Symfony 5.3, UserProviderInterface in Symfony suggest to use loadUserByIdentifier to replace loadUserByUsername

https://github.com/symfony/symfony/blob/1e968b49f516d8b1305d0b94158dabef557d334e/src/Symfony/Component/Security/Core/User/UserProviderInterface.php#L61-L68

Since Symfony 5.3, UserProviderInterface in Symfony use loadUserByIdentifier to replace loadUserByUsername
@kayue kayue requested a review from a team as a code owner December 15, 2021 06:42
@Zales0123 Zales0123 added DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Dec 22, 2021
@Zales0123 Zales0123 merged commit 7a9f89b into Sylius:master Dec 22, 2021
@Zales0123
Copy link
Member

Thank you, @kayue! 🎉

@kayue kayue deleted the patch-12 branch December 23, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience. Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants