Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] managing product attributes from API #13414

Closed
laurentdabbb opened this issue Dec 21, 2021 · 4 comments
Closed

[API] managing product attributes from API #13414

laurentdabbb opened this issue Dec 21, 2021 · 4 comments
Labels
API APIs related issues and PRs. Feature New feature proposals.

Comments

@laurentdabbb
Copy link

laurentdabbb commented Dec 21, 2021

Hi,

Sorry in advance, if I missed an already opened issue about managing productAttribute from API.
I can't figure how to retrieve a productAttribute value from API. This feature seems to be actually missing.

I think this should be added to the #11250 roadmap about features requested to the community.

Complete CRUD features would be nice, but in a first time simply retrieving productAttribute values attached to a product would be great.

It's quite easy for simple productAttribute type like "text", but a little bit more complex for "select" which values are stored in a serialized format.

I don't know if product attributes should be directly available form product serialization or only from a specific endpoint (subresource) for performance reasons.

Thank you and sorry again if a similar issue already exists.

@Zales0123 Zales0123 added API APIs related issues and PRs. Feature New feature proposals. labels Jan 4, 2022
@Zales0123
Copy link
Member

Hello @laurentdabbb. Indeed, it would be great to do it :) However, we're currently focusing on Shop API, so it's not a priority for us now. However, if you would like to give it a try and open a PR with such a change, we would be happy to merge it and/or help with potential problems. Tip: regarding different structures for different types, you can take a look at CatalogPromotion's API, as this is a similar case 🖖 🐎

@laurentdabbb
Copy link
Author

OK, thanks for your feedback.
I implemented a new endpoint specifically to what I need, so not enought generic to open a PR ;-)
I will take a look to CatalogPromotion's API.

Thx

@coldic3
Copy link
Contributor

coldic3 commented Jun 6, 2022

Hey @laurentdabbb. I come with a small update 💃 Recently we added GET methods for retrieving product attributes in the shop (here #13928). It's still not fully covered CRUD but maybe you find it useful 🙂 You can test it out on the master demo https://master.demo.sylius.com/api/v2 if you wish. These endpoints should appear in the next Sylius/Sylius release.

@NoResponseMate
Copy link
Contributor

Hi @laurentdabbb 👋

Management of product attributes via the API has been added in 1.13.

Cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API APIs related issues and PRs. Feature New feature proposals.
Projects
None yet
Development

No branches or pull requests

4 participants