Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using phparkitect github actions #13454

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Using phparkitect github actions #13454

merged 1 commit into from
Jan 14, 2022

Conversation

AlessandroMinoccheri
Copy link
Contributor

@AlessandroMinoccheri AlessandroMinoccheri commented Jan 9, 2022 •
edited by Zales0123
Loading

Q A
Branch? 1.10
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

@AlessandroMinoccheri AlessandroMinoccheri requested a review from a team as a code owner January 9, 2022 17:26
@probot-autolabeler probot-autolabeler bot added the Maintenance CI configurations, READMEs, releases, etc. label Jan 9, 2022
lchrusciel
lchrusciel approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@lchrusciel lchrusciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Alessandro,

thanks a lot for your PR. Can you rebase your work to newest master? That should fix the build

@AlessandroMinoccheri
Copy link
Contributor Author

Done @lchrusciel :)

@Zales0123 Zales0123 changed the base branch from master to 1.10 January 14, 2022 10:04
@Zales0123
Copy link
Member

The base of this pull-request was changed, you need fetch and reset your local branch
if you want to add new commits to this pull request. Reset before you pull, else commits
may become messed-up.

Unless you added new commits (to this branch) locally that you did not push yet,
execute git fetch origin && git reset "use-phparkitect-github-actions" to update your local branch.

Feel free to ask for assistance when you get stuck 👍

@Zales0123 Zales0123 force-pushed the use-phparkitect-github-actions branch from b8dd1a6 to 2af12d4 Compare January 14, 2022 10:04
@probot-autolabeler probot-autolabeler bot added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Jan 14, 2022
@AlessandroMinoccheri @Zales0123
using phparkitect github actions
c0bf965 
fix github actions for phparkitect

Bump payum/payum to 1.7
@Zales0123 Zales0123 force-pushed the use-phparkitect-github-actions branch from c3b5e07 to c0bf965 Compare January 14, 2022 10:58
@Zales0123
Copy link
Member

Hey @AlessandroMinoccheri, I've allowed myself to rebase your PR 🖖 it should be ready to merge after the build is green :) thanks!

@AlessandroMinoccheri
Copy link
Contributor Author

Ok thanks @Zales0123

@GSadee GSadee merged commit aae0651 into Sylius:1.10 Jan 14, 2022
@GSadee
Copy link
Member

GSadee commented Jan 14, 2022

Thank you, Alessandro! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@Zales0123 Zales0123 Zales0123 approved these changes

@lchrusciel lchrusciel lchrusciel approved these changes

Assignees
No one assigned
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals. Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AlessandroMinoccheri @Zales0123 @GSadee @lchrusciel