Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied promotion information formatter service configuration cleanup #13458

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Applied promotion information formatter service configuration cleanup #13458

merged 1 commit into from
Jan 11, 2022

Conversation

Rafikooo
Copy link
Contributor

@Rafikooo Rafikooo commented Jan 10, 2022 •
edited
Loading

Q A
Branch? 1.11
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

Before and after code changes:
Screenshot 2022-01-08 at 21 43 08

@Rafikooo Rafikooo added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Jan 10, 2022
@Rafikooo Rafikooo requested a review from a team as a code owner January 10, 2022 12:18
@GSadee GSadee merged commit 99499ad into Sylius:1.11 Jan 11, 2022
@GSadee
Copy link
Member

GSadee commented Jan 11, 2022

Thanks, Rafał! 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSadee GSadee GSadee approved these changes

@SirDomin SirDomin SirDomin approved these changes

@AdamKasp AdamKasp Awaiting requested review from AdamKasp

@lchrusciel lchrusciel Awaiting requested review from lchrusciel

Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Rafikooo @GSadee @SirDomin