Catalog promotion priority #13465
Catalog promotion priority #13465
Conversation
Rafikooo
commented
Jan 11, 2022
Rafikooo
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| License | MIT |
probot-autolabeler
bot
added
the
Documentation
| @@ -7,7 +7,7 @@ | |||
| "code": "mugs_discount", | |||
| "startDate": null, | |||
| "endDate": null, | |||
| "priority": 1000, | |||
| "priority": 0, | |||
There was a problem hiding this comment.
Having one row in the database when updating, gedmo sets the priority to 0, even if the value given is different, similar behavior like described in the other comment
blank line nl test update
…logPromotion entity
| @@ -12,7 +12,6 @@ Feature: Seeing catalog promotion's details | |||
| And it applies also on "T-Shirt" product | |||
| And it reduces also price by fixed "$10.00" in the "Web-US" channel | |||
| And the catalog promotion "Winter sale" operates between "2021-11-10" and "2022-01-08" | |||
| And its priority is 1200 | |||
There was a problem hiding this comment.
The default priority value when creating is 0, which is in this scenario. This step updates the database row, but gedmo cannot allow to set different priority values when only one row existing thus I decided to remove that act.
Alternatively, I can set this value to 1200 during creating, and then gedmo allows it
| @@ -24,4 +23,3 @@ Feature: Seeing catalog promotion's details | |||
| And it should apply on "PHP T-Shirt" variant | |||
| And it should apply on "T-Shirt" product | |||
| And it should start at "2021-11-10" and end at "2022-01-08" | |||
| And its priority should be 1200 | |||
There was a problem hiding this comment.
With current behavior, I can assert that the priority value is 0
|
|
||
| @api @ui | ||
| Scenario: Adding a catalog promotion with a priority lower than all existing ones | ||
| increases the priority value of other catalog promotions by 1 |
There was a problem hiding this comment.
I am not sure if we need these details, in the scenario we are describing what we do, not an effect, IMO assertions are enough to understand priorities logic :)
|
Thank you, Rafał! 🎉 |
