[CatalogPromotion] Introduce CatalogPromotionCreated event #13473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jan 12, 2022
GSadee
commented
| Q | A |
|---|---|
| Branch? | 1.11 |
| Bug fix? | no |
| New feature? | no? |
| BC breaks? | no |
| Deprecations? | |
| Related tickets | |
| License | MIT |
GSadee
added
Enhancement
probot-autolabeler
bot
added
the
Documentation
AdamKasp
approved these changes
Jan 12, 2022
SirDomin
approved these changes
Jan 12, 2022
GSadee
force-pushed
the
add-catalog-promotion-created-event
branch
from
f596ca2
to
a8115c4
Compare
lchrusciel
approved these changes
Jan 13, 2022
Comment on lines
+50
to
+55
| $this->eventBus->dispatch( | ||
| new CatalogPromotionCreated($catalogPromotion->getCode()), | ||
| $this->calculateStartDateStamp($catalogPromotion) | ||
| ); | ||
|
|
||
| $this->dispatchCatalogPromotionEndedEvent($catalogPromotion); |
There was a problem hiding this comment.
I'm wondering if in the next iteration we couldn't extract this logic and reuse it here and in Api Platform context. Same for update action
|
Thanks, Grzegorz! 🥇 |
lchrusciel
added a commit
that referenced
this pull request
Jan 19, 2022
…ion events from listeners to a separate service (GSadee) This PR was merged into the 1.11 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.11 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Related tickets | fixes #13473 (review) | License | MIT <!-- - Bug fixes must be submitted against the 1.10 or 1.11 branch(the lowest possible) - Features and deprecations must be submitted against the master branch - Make sure that the correct base branch is set To be sure you are not breaking any Backward Compatibilities, check the documentation: https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html --> Commits ------- 2676c9c [CatalogPromotion] Extract dispatching catalog promotion events from listeners to a separate service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.