Remove Symfony 4 circular dependency exception listener fix #13528
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed two classes and its tests:
Sylius\Bundle\CoreBundle\DependencyInjection\Compiler\CircularDependencyBreakingExceptionListenerPass
Sylius\Bundle\CoreBundle\EventListener\CircularDependencyBreakingExceptionListener
The second one (the listener) was marked as
@internal
so it can be removed without breaking the BC promise. The first one was not marked as internal so its removal is a BC break.Let me know what you prefer, its only job was to add the listener but we can also not remove it and leave it empty.