Refactor catalog promotions - process variants instead promotion #13536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamKasp
changed the title
AdamKasp
commented
Jan 25, 2022
src/Sylius/Bundle/CoreBundle/CommandHandler/VariantsUpdateHandler.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
from
57c3b91
to
f0df531
Compare
probot-autolabeler
bot
added
Documentation
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
2 times, most recently
from
89ae455
to
39beb76
Compare
GSadee
reviewed
Jan 26, 2022
src/Sylius/Bundle/CoreBundle/Announcer/BatchedVariantsUpdateAnnouncer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Announcer/BatchedVariantsUpdateAnnouncer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/CommandHandler/VariantsUpdateHandler.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Jan 26, 2022
src/Sylius/Bundle/CoreBundle/Announcer/BatchedVariantsUpdateAnnouncer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Announcer/BatchedVariantsUpdateAnnouncer.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/CommandHandler/VariantsUpdateHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/CommandHandler/VariantsUpdateHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/CommandHandler/VariantsUpdateHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Announcer/BatchedVariantsUpdateAnnouncerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Announcer/BatchedVariantsUpdateAnnouncerSpec.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Processor/AllCatalogPromotionsProcessorSpec.php
Outdated
Show resolved
Hide resolved
lchrusciel
reviewed
Jan 26, 2022
There was a problem hiding this comment.
General problem, that exist with this implementation is the usage of CatalogPromotionApplicatorInterface - this service is checking only for exclusiveness or minimum price, both on channel pricing, but (if I see correctly) we are never checking scopes of promotions if they should be applied. At least, I don't see VarinatProvider usage here nor reimplementation of it. This suggest, that we have weak test coverage if we didn't detect it earlier
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
5 times, most recently
from
526a744
to
9d2b663
Compare
Zales0123
reviewed
Jan 27, 2022
src/Sylius/Bundle/CoreBundle/Commander/UpdateVariantsCommander.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/AllCatalogPromotionsProcessor.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/CommandHandler/UpdateVariantsHandler.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Processor/ProductCatalogPromotionsProcessor.php
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Resources/config/services/listeners.xml
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Applicator/CatalogPromotionApplicatorSpec.php
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/spec/Commander/UpdateVariantsCommanderSpec.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
2 times, most recently
from
6a89290
to
ebb2131
Compare
lchrusciel
reviewed
Jan 27, 2022
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionApplicableOnVariantChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/CatalogPromotionApplicableOnVariantChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/InForTaxonsScopeVariantChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/InForVariantsScopeVariantChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/Checker/InForProductScopeVariantChecker.php
Outdated
Show resolved
Hide resolved
src/Sylius/Bundle/CoreBundle/CommandHandler/UpdateVariantsHandler.php
Outdated
Show resolved
Hide resolved
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
9 times, most recently
from
495c41c
to
b9a9609
Compare
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
from
79930d4
to
6ade27f
Compare
AdamKasp
force-pushed
the
catalog-promotion-refactor
branch
from
dee4a36
to
b28a47e
Compare
lchrusciel
reviewed
Jan 31, 2022
Comment on lines
+34
to
+40
| # @api @ui @todo | ||
| # Scenario: Enabling catalog promotion during its operating time | ||
| # Given the catalog promotion "Christmas sale" operates between "yesterday" and "tomorrow" | ||
| # And this catalog promotion is disabled | ||
| # When I enable "Christmas sale" catalog promotion | ||
| # Then this catalog promotion should be active | ||
| # And "PHP T-Shirt" variant should be discounted |
There was a problem hiding this comment.
`todo tag should be enough. Please revert. If the tests will be still executed, we need to improve GH Action step
| interface ForVariantInCatalogPromotionScopeCheckerProviderInterface | ||
| { | ||
| public function provide(CatalogPromotionScopeInterface $scope): VariantInScopeCheckerInterface; | ||
|
|
| use Sylius\Bundle\PromotionBundle\Provider\EligibleCatalogPromotionsProviderInterface; | ||
| use Sylius\Component\Core\Model\CatalogPromotionInterface; | ||
| use Sylius\Bundle\CoreBundle\CommandDispatcher\ApplyCatalogPromotionsOnVariantsCommandDispatcherInterface; | ||
| use Sylius\Component\Core\Repository\ProductVariantRepositoryInterface; | ||
|
|
||
| final class AllCatalogPromotionsProcessor implements AllCatalogPromotionsProcessorInterface |
There was a problem hiding this comment.
Suggested change
| final class AllCatalogPromotionsProcessor implements AllCatalogPromotionsProcessorInterface | |
| final class AllProductVariantsCatalogPromotionsProcessor implements AllProductVariantCatalogPromotionsProcessorInterface |
lchrusciel
changed the title
|
Thank you, Adam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make it possible to optimise Catalog Promotions processing, we want to process catalog promotion per variants in batches. the current solution prevents parallelization of the work.
it is initial PR.